From 06c9d77bc5b500f036b2a94e0d7b1eb61af7fbed Mon Sep 17 00:00:00 2001 From: SUZUKI Sosuke Date: Thu, 8 Feb 2024 23:05:58 +0900 Subject: [PATCH] perf: Use logical expression instead of regexp for `isUnitTestSetUp` (#16035) --- src/language-js/utils/index.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/language-js/utils/index.js b/src/language-js/utils/index.js index 4f5c87fbc..a9a59f104 100644 --- a/src/language-js/utils/index.js +++ b/src/language-js/utils/index.js @@ -323,15 +323,16 @@ function isSimpleType(node) { } /** - * @param {CallExpression} node + * @param {*} node * @returns {boolean} */ -function isUnitTestSetUp(node) { - const unitTestSetUpRe = /^(?:before|after)(?:Each|All)$/; +function isUnitTestSetupIdentifier(node) { return ( - node.callee.type === "Identifier" && - node.arguments.length === 1 && - unitTestSetUpRe.test(node.callee.name) + node.type === "Identifier" && + (node.name === "beforeEach" || + node.name === "beforeAll" || + node.name === "afterEach" || + node.name === "afterAll") ); } @@ -375,7 +376,7 @@ function isTestCall(node, parent) { return isFunctionOrArrowExpression(node.arguments[0]); } - if (isUnitTestSetUp(node)) { + if (isUnitTestSetupIdentifier(node.callee)) { return isAngularTestWrapper(node.arguments[0]); } } else if (