From 4dfe92a76b7d2fa0983a79786b57f6005e369f0d Mon Sep 17 00:00:00 2001 From: Brian Ng Date: Thu, 13 Apr 2017 09:09:40 -0500 Subject: [PATCH] Ensure JSXOpeningElement does not break with single text attr on Babylon (#1229) --- src/printer.js | 3 ++- tests/jsx-newlines/jsfmt.spec.js | 2 +- tests/jsx-split-attrs/jsfmt.spec.js | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/printer.js b/src/printer.js index 8ed341c58..d286ca5c3 100644 --- a/src/printer.js +++ b/src/printer.js @@ -1296,7 +1296,8 @@ function genericPrintNoParens(path, options, print, args) { if ( n.attributes.length === 1 && n.attributes[0].value && - n.attributes[0].value.type === "Literal" && + (n.attributes[0].value.type === "Literal" || + n.attributes[0].value.type === "StringLiteral") && typeof n.attributes[0].value.value === "string" ) { return group( diff --git a/tests/jsx-newlines/jsfmt.spec.js b/tests/jsx-newlines/jsfmt.spec.js index 7580dfab0..c426c19cc 100644 --- a/tests/jsx-newlines/jsfmt.spec.js +++ b/tests/jsx-newlines/jsfmt.spec.js @@ -1 +1 @@ -run_spec(__dirname, null, ["typescript"]); +run_spec(__dirname, null, ["babylon", "typescript"]); diff --git a/tests/jsx-split-attrs/jsfmt.spec.js b/tests/jsx-split-attrs/jsfmt.spec.js index 7580dfab0..c426c19cc 100644 --- a/tests/jsx-split-attrs/jsfmt.spec.js +++ b/tests/jsx-split-attrs/jsfmt.spec.js @@ -1 +1 @@ -run_spec(__dirname, null, ["typescript"]); +run_spec(__dirname, null, ["babylon", "typescript"]);