From 53da86c34dd1c1e1241e85c57469100f2467fcec Mon Sep 17 00:00:00 2001
From: fisker Cheung <lionkay@gmail.com>
Date: Mon, 17 Jan 2022 09:19:50 +0800
Subject: [PATCH] Fix some lgtm alerts (#12084)

---
 scripts/release/steps/bump-prettier.js          |  2 +-
 scripts/release/steps/update-version.js         |  2 +-
 src/language-html/embed.js                      | 12 ++++++------
 src/language-js/parse/postprocess/typescript.js |  3 ++-
 4 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/scripts/release/steps/bump-prettier.js b/scripts/release/steps/bump-prettier.js
index de98b4bd8..9424e6f30 100644
--- a/scripts/release/steps/bump-prettier.js
+++ b/scripts/release/steps/bump-prettier.js
@@ -33,7 +33,7 @@ async function bump({
   } else {
     pkg.version = semver.inc(version, "minor") + "-dev";
   }
-  await writeJson("package.json", pkg, { spaces: 2 });
+  await writeJson("package.json", pkg);
 }
 
 export default async function bumpPrettier(params) {
diff --git a/scripts/release/steps/update-version.js b/scripts/release/steps/update-version.js
index 5b9a8315d..b97cbe7da 100644
--- a/scripts/release/steps/update-version.js
+++ b/scripts/release/steps/update-version.js
@@ -9,7 +9,7 @@ import {
 async function bump({ version }) {
   const pkg = await readJson("package.json");
   pkg.version = version;
-  await writeJson("package.json", pkg, { spaces: 2 });
+  await writeJson("package.json", pkg);
 
   // Update github issue templates
   processFile(".github/ISSUE_TEMPLATE/formatting.md", (content) =>
diff --git a/src/language-html/embed.js b/src/language-html/embed.js
index c247dd1fc..2ca96c4d6 100644
--- a/src/language-html/embed.js
+++ b/src/language-html/embed.js
@@ -31,7 +31,7 @@ const {
 } = require("./utils.js");
 const getNodeContent = require("./get-node-content.js");
 
-function printEmbeddedAttributeValue(node, originalTextToDoc, options) {
+function printEmbeddedAttributeValue(node, htmlTextToDoc, options) {
   const isKeyMatched = (patterns) =>
     new RegExp(patterns.join("|")).test(node.fullName);
   const getValue = () => unescapeQuoteEntities(node.value);
@@ -67,11 +67,11 @@ function printEmbeddedAttributeValue(node, originalTextToDoc, options) {
   const printMaybeHug = (doc) => (shouldHug ? printHug(doc) : printExpand(doc));
 
   const attributeTextToDoc = (code, opts) =>
-    originalTextToDoc(
-      code,
-      { __onHtmlBindingRoot, __embeddedInHtml: true, ...opts },
-      { stripTrailingHardline: true }
-    );
+    htmlTextToDoc(code, {
+      __onHtmlBindingRoot,
+      __embeddedInHtml: true,
+      ...opts,
+    });
 
   if (
     node.fullName === "srcset" &&
diff --git a/src/language-js/parse/postprocess/typescript.js b/src/language-js/parse/postprocess/typescript.js
index a90422a73..329280a70 100644
--- a/src/language-js/parse/postprocess/typescript.js
+++ b/src/language-js/parse/postprocess/typescript.js
@@ -63,7 +63,8 @@ function throwErrorForInvalidAbstractProperty(tsNode, esTreeNode) {
 function throwErrorForInvalidNodes(ast, options) {
   const { esTreeNodeToTSNodeMap, tsNodeToESTreeNodeMap } =
     options.tsParseResult;
-  ast = visitNode(ast, (node) => {
+
+  visitNode(ast, (node) => {
     const tsNode = esTreeNodeToTSNodeMap.get(node);
     if (!tsNode) {
       return;