From 63f2bc2021518178d8d020457142ac41d89cf4bb Mon Sep 17 00:00:00 2001 From: fisker Cheung Date: Wed, 24 Sep 2025 04:20:44 +0800 Subject: [PATCH] Add `"sideEffects": false` to package.json (#17949) --- package.json | 3 ++- packages/plugin-hermes/package.json | 3 ++- packages/plugin-oxc/package.json | 3 ++- scripts/build/build-dependencies-license.js | 3 +-- scripts/build/build-package-json.js | 1 + 5 files changed, 8 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index b00624c43..8e78da269 100644 --- a/package.json +++ b/package.json @@ -220,5 +220,6 @@ "not op_mini all" ], "preferUnplugged": true, - "packageManager": "yarn@4.9.2" + "packageManager": "yarn@4.10.3", + "sideEffects": false } diff --git a/packages/plugin-hermes/package.json b/packages/plugin-hermes/package.json index 1d844f59a..3a9eb850b 100644 --- a/packages/plugin-hermes/package.json +++ b/packages/plugin-hermes/package.json @@ -18,5 +18,6 @@ "funding": "https://github.com/prettier/prettier?sponsor=1", "homepage": "https://github.com/prettier/prettier/tree/main/packages/plugin-hermes", "author": "fisker Cheung ", - "license": "MIT" + "license": "MIT", + "sideEffects": false } diff --git a/packages/plugin-oxc/package.json b/packages/plugin-oxc/package.json index 0ea20ac77..f4c6eeb03 100644 --- a/packages/plugin-oxc/package.json +++ b/packages/plugin-oxc/package.json @@ -18,5 +18,6 @@ "funding": "https://github.com/prettier/prettier?sponsor=1", "homepage": "https://github.com/prettier/prettier/tree/main/packages/plugin-oxc", "author": "fisker Cheung ", - "license": "MIT" + "license": "MIT", + "sideEffects": false } diff --git a/scripts/build/build-dependencies-license.js b/scripts/build/build-dependencies-license.js index 1a98edd2c..d75d8e589 100644 --- a/scripts/build/build-dependencies-license.js +++ b/scripts/build/build-dependencies-license.js @@ -134,8 +134,7 @@ async function buildDependenciesLicense({ throw new Error(`${fileName} should be last file to build.`); } - const shouldBuildLicense = - !cliOptions.files && typeof cliOptions.minify !== "boolean"; + const shouldBuildLicense = !cliOptions.files; if (!shouldBuildLicense) { return { skipped: true }; diff --git a/scripts/build/build-package-json.js b/scripts/build/build-package-json.js index d8b6186e3..e9f7f7fe6 100644 --- a/scripts/build/build-package-json.js +++ b/scripts/build/build-package-json.js @@ -23,6 +23,7 @@ const keysToKeep = [ "engines", "files", "preferUnplugged", + "sideEffects", ]; const publishConfig = {