From 75c8d46ab487fe55deeb31fcad1b4768c76560f1 Mon Sep 17 00:00:00 2001 From: Sosuke Suzuki Date: Sun, 17 Jul 2022 04:26:27 +0900 Subject: [PATCH] Drop Node.js 12 Support (#13118) * Drop Node.js 12 Support * Update CHANGELOG * Update build target * Comment out * Remove node 14 from `exclude` * Update CI * Update changelog_unreleased/api/11830.md --- .github/workflows/prod-test.yml | 7 +------ changelog_unreleased/api/11830.md | 4 ++-- scripts/build/build.mjs | 3 ++- scripts/build/bundler.mjs | 2 +- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/prod-test.yml b/.github/workflows/prod-test.yml index c5a67795d..c882aa7fd 100644 --- a/.github/workflows/prod-test.yml +++ b/.github/workflows/prod-test.yml @@ -71,7 +71,6 @@ jobs: - "18" - "16" - "14" - - "12" include: - os: "ubuntu-latest" node: "18" @@ -79,12 +78,8 @@ jobs: exclude: - os: "macos-latest" node: "16" - - os: "macos-latest" - node: "14" - os: "windows-latest" node: "16" - - os: "windows-latest" - node: "14" env: FULL_TEST: ${{ matrix.FULL_TEST }} name: Node.js ${{ matrix.node }} on ${{ matrix.os }} @@ -155,4 +150,4 @@ jobs: run: node -v | grep "v0.10.48" || exit 1 - name: Run CLI on Node.js v0.10.48 - run: node dist/bin-prettier --version 2>&1 >/dev/null | grep "prettier requires at least version 12.17.0 of Node, please upgrade" || exit 1 + run: node dist/bin-prettier --version 2>&1 >/dev/null | grep "prettier requires at least version 14 of Node, please upgrade" || exit 1 diff --git a/changelog_unreleased/api/11830.md b/changelog_unreleased/api/11830.md index d6e7036e9..40e361aed 100644 --- a/changelog_unreleased/api/11830.md +++ b/changelog_unreleased/api/11830.md @@ -1,3 +1,3 @@ -#### [Breaking] Drop support for Node.js 10 (#11830 by @fisker) +#### [Breaking] Drop support for Node.js 10 and 12 (#11830 by @fisker, #13118 by @sosukesuzuki) -The minimal required Node.js version is v12.17.0 +The minimal required Node.js version is v14 diff --git a/scripts/build/build.mjs b/scripts/build/build.mjs index 96f21abe6..378343519 100644 --- a/scripts/build/build.mjs +++ b/scripts/build/build.mjs @@ -133,7 +133,8 @@ async function createBundle(bundleConfig, options) { async function preparePackage() { const packageJson = await readJson(path.join(PROJECT_ROOT, "package.json")); packageJson.bin = "./bin-prettier.js"; - packageJson.engines.node = ">=12.17.0"; + // https://github.com/prettier/prettier/pull/13118#discussion_r922708068 + // packageJson.engines.node = ">=14.20.0"; delete packageJson.dependencies; delete packageJson.devDependencies; delete packageJson.browserslist; diff --git a/scripts/build/bundler.mjs b/scripts/build/bundler.mjs index ae622db7d..03f23196f 100644 --- a/scripts/build/bundler.mjs +++ b/scripts/build/bundler.mjs @@ -210,7 +210,7 @@ function* getEsbuildOptions(bundle, buildOptions) { external: ["pnpapi", ...(bundle.external ?? [])], // Disable esbuild auto discover `tsconfig.json` file tsconfig: path.join(dirname, "empty-tsconfig.json"), - target: [...(bundle.esbuildTarget ?? ["node12"])], + target: [...(bundle.esbuildTarget ?? ["node14"])], logLevel: "error", };