From 8a85ba4e1877155819ca118be83e0cabe171159c Mon Sep 17 00:00:00 2001 From: fisker Cheung Date: Sun, 21 Nov 2021 00:44:28 +0800 Subject: [PATCH] Update `acorn` (#11835) * Update `acorn` * Fix test, add changelog --- changelog_unreleased/javascript/11835.md | 29 +++++++++++++++++++ .../__snapshots__/jsfmt.spec.js.snap | 11 ------- tests/format/js/babel-plugins/jsfmt.spec.js | 1 - yarn.lock | 6 ++-- 4 files changed, 32 insertions(+), 15 deletions(-) create mode 100644 changelog_unreleased/javascript/11835.md diff --git a/changelog_unreleased/javascript/11835.md b/changelog_unreleased/javascript/11835.md new file mode 100644 index 000000000..eb7e51eb7 --- /dev/null +++ b/changelog_unreleased/javascript/11835.md @@ -0,0 +1,29 @@ +#### Support ES2022 class-private-fields-in syntax in `espree` parser (#11835 by @fisker) + + +```jsx +// Input +class Foo { + #brand; + static isC(obj) { + return #brand in Foo; + } +} + +// Prettier stable +SyntaxError: Unexpected token #brand (4:12) + 2 | #brand; + 3 | static isC(obj) { +> 4 | return #brand in Foo; + | ^ + 5 | } + 6 | } + +// Prettier main +class Foo { + #brand; + static isC(obj) { + return #brand in Foo; + } +} +``` diff --git a/tests/format/js/babel-plugins/__snapshots__/jsfmt.spec.js.snap b/tests/format/js/babel-plugins/__snapshots__/jsfmt.spec.js.snap index 43fbdf12c..c9e348e3d 100644 --- a/tests/format/js/babel-plugins/__snapshots__/jsfmt.spec.js.snap +++ b/tests/format/js/babel-plugins/__snapshots__/jsfmt.spec.js.snap @@ -1704,17 +1704,6 @@ result; //=> "Hello, hello!" ================================================================================ `; -exports[`private-fields-in-in.js [espree] format 1`] = ` -"Unexpected token #brand (44:12) - 42 | - 43 | static isC(obj) { -> 44 | return #brand in obj && #method in obj && #getter in obj; - | ^ - 45 | } - 46 | } - 47 |" -`; - exports[`private-fields-in-in.js format 1`] = ` ====================================options===================================== parsers: ["babel", "babel-ts", "babel-flow"] diff --git a/tests/format/js/babel-plugins/jsfmt.spec.js b/tests/format/js/babel-plugins/jsfmt.spec.js index 4596b4824..21241cb17 100644 --- a/tests/format/js/babel-plugins/jsfmt.spec.js +++ b/tests/format/js/babel-plugins/jsfmt.spec.js @@ -17,7 +17,6 @@ run_spec(__dirname, ["babel", "babel-ts", "babel-flow"], { "pipeline-operator-fsharp.js", "pipeline-operator-minimal.js", "pipeline-operator-hack.js", - "private-fields-in-in.js", "record-tuple-record.js", "record-tuple-tuple.js", "throw-expressions.js", diff --git a/yarn.lock b/yarn.lock index d878e7844..28e01f1f1 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1994,9 +1994,9 @@ acorn@^7.1.1: integrity sha512-nQyp0o1/mNdbTO1PO6kHkwSrmgZ0MT/jCCpNiwbUjGoRN4dlBhqJtoQuCnEOKzgTVwg0ZWiCoQy6SxMebQVh8A== acorn@^8.2.4, acorn@^8.4.1, acorn@^8.5.0: - version "8.5.0" - resolved "https://registry.yarnpkg.com/acorn/-/acorn-8.5.0.tgz#4512ccb99b3698c752591e9bb4472e38ad43cee2" - integrity sha512-yXbYeFy+jUuYd3/CDcg2NkIYE991XYX/bje7LmjJigUciaeO1JR4XxXgCIV1/Zc/dRuFEyw1L0pbA+qynJkW5Q== + version "8.6.0" + resolved "https://registry.yarnpkg.com/acorn/-/acorn-8.6.0.tgz#e3692ba0eb1a0c83eaa4f37f5fa7368dd7142895" + integrity sha512-U1riIR+lBSNi3IbxtaHOIKdH8sLFv3NYfNv8sg7ZsNhcfl4HF2++BfqqrNAxoCLQW1iiylOj76ecnaUxz+z9yw== agent-base@6: version "6.0.2"