GraphQL: Support "Fragment arguments" (#19297)

changelog_unreleased/graphql/19171.md

@@ -1,4 +1,4 @@
-#### Support directives on directive definitions (#19171 by @YBJ0000)
+#### Support "directives on directive definitions" (#19171 by @YBJ0000)
 
 [Directives on directive definitions](https://github.com/graphql/graphql-js/pull/4521) (and `extend directive` extensions) are now supported.
 

changelog_unreleased/graphql/19297.md

@@ -0,0 +1,23 @@
+#### Support "Fragment arguments" (#19297 by @fisker)
+
+[Fragment arguments](https://github.com/graphql/graphql-js/pull/4015) are now supported.
+
+<!-- prettier-ignore -->
+```gql
+# Input
+fragment variableProfilePic on User {
+  ...dynamicProfilePic(size: $size)
+}
+
+# Prettier stable
+SyntaxError: Syntax Error: Expected Name, found "(". (2:23)
+  1 | fragment variableProfilePic on User {
+> 2 |   ...dynamicProfilePic(size: $size)
+    |                       ^
+  3 | }
+
+# Prettier main
+fragment variableProfilePic on User {
+  ...dynamicProfilePic(size: $size)
+}
+```

src/language-graphql/printer-graphql.js

@@ -167,6 +167,7 @@ function genericPrint(path, options, print) {
 
     case "ObjectField":
     case "Argument":
+    case "FragmentArgument":
       return [print("name"), ": ", print("value")];
 
     case "Directive":
@@ -373,7 +374,12 @@ function genericPrint(path, options, print) {
       return [node.operation, ": ", print("type")];
 
     case "FragmentSpread":
-      return ["...", print("name"), printDirectives(path, print)];
+      return [
+        "...",
+        print("name"),
+        printArguments(path, options, print),
+        printDirectives(path, print),
+      ];
 
     case "InlineFragment":
       return [

src/language-graphql/visitor-keys.js

@@ -13,10 +13,4 @@ for (const kind of [
   delete visitorKeys[kind];
 }
 
-// Not supported yet
-visitorKeys.FragmentSpread = visitorKeys.FragmentSpread.filter(
-  (key) => key !== "arguments",
-);
-delete visitorKeys.FragmentArgument;
-
 export default visitorKeys;

tests/format/graphql/fragment-arguments/__snapshots__/format.test.js.snap

@@ -0,0 +1,46 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`fragment-arguemnts.graphql format 1`] = `
+====================================options=====================================
+parsers: ["graphql"]
+                                                      printWidth: 80 (default) |
+=====================================input======================================
+query withShadowedVariables($size: Int!) {
+  user(id: 4) {
+    ...variableProfilePic
+  }
+  secondUser: user(id: 5) {
+    ...dynamicProfilePic(size: 10)
+  }
+}
+
+fragment variableProfilePic on User {
+  ...dynamicProfilePic(size: $size)
+}
+
+fragment a on t { ...b(v: $v) }
+fragment a on t { ...b(v: $v) @foo }
+
+=====================================output=====================================
+query withShadowedVariables($size: Int!) {
+  user(id: 4) {
+    ...variableProfilePic
+  }
+  secondUser: user(id: 5) {
+    ...dynamicProfilePic(size: 10)
+  }
+}
+
+fragment variableProfilePic on User {
+  ...dynamicProfilePic(size: $size)
+}
+
+fragment a on t {
+  ...b(v: $v)
+}
+fragment a on t {
+  ...b(v: $v) @foo
+}
+
+================================================================================
+`;

tests/format/graphql/fragment-arguments/format.test.js

@@ -0,0 +1 @@
+runFormatTest(import.meta, ["graphql"]);

tests/format/graphql/fragment-arguments/fragment-arguemnts.graphql

@@ -0,0 +1,15 @@
+query withShadowedVariables($size: Int!) {
+  user(id: 4) {
+    ...variableProfilePic
+  }
+  secondUser: user(id: 5) {
+    ...dynamicProfilePic(size: 10)
+  }
+}
+
+fragment variableProfilePic on User {
+  ...dynamicProfilePic(size: $size)
+}
+
+fragment a on t { ...b(v: $v) }
+fragment a on t { ...b(v: $v) @foo }

tests/unit/__snapshots__/visitor-keys.js.snap

@@ -1337,6 +1337,10 @@ exports[`visitor keys graphql 1`] = `
     "type",
   ],
   "FloatValue": [],
+  "FragmentArgument": [
+    "name",
+    "value",
+  ],
   "FragmentDefinition": [
     "description",
     "directives",
@@ -1346,6 +1350,7 @@ exports[`visitor keys graphql 1`] = `
     "variableDefinitions",
   ],
   "FragmentSpread": [
+    "arguments",
     "directives",
     "name",
   ],