From 99bc9d0b6d3a9bcc0de6e99786502fba2d29b4fe Mon Sep 17 00:00:00 2001
From: fisker Cheung <lionkay@gmail.com>
Date: Wed, 7 Feb 2024 16:44:36 +0800
Subject: [PATCH] Improve readability of `isStringKeySafeToUnquote` (#16056)

---
 src/language-js/print/property.js | 60 +++++++++++++++++++------------
 1 file changed, 38 insertions(+), 22 deletions(-)

diff --git a/src/language-js/print/property.js b/src/language-js/print/property.js
index 24aaf1c1a..569a40206 100644
--- a/src/language-js/print/property.js
+++ b/src/language-js/print/property.js
@@ -40,28 +40,44 @@ function isSimpleNumber(numberString) {
 //
 // Identifiers can be unquoted in more circumstances, though.
 function isStringKeySafeToUnquote(node, options) {
-  return (
-    options.parser !== "json" &&
-    options.parser !== "jsonc" &&
-    isStringLiteral(node.key) &&
-    rawText(node.key).slice(1, -1) === node.key.value &&
-    ((isEs5IdentifierName(node.key.value) &&
-      // With `--strictPropertyInitialization`, TS treats properties with quoted names differently than unquoted ones.
-      // See https://github.com/microsoft/TypeScript/pull/20075
-      !(
-        (options.parser === "babel-ts" && node.type === "ClassProperty") ||
-        (options.parser === "typescript" && node.type === "PropertyDefinition")
-      )) ||
-      (isSimpleNumber(node.key.value) &&
-        String(Number(node.key.value)) === node.key.value &&
-        // TODO[@fisker]: `ImportAttribute` should not care about parser
-        node.type !== "ImportAttribute" &&
-        (options.parser === "babel" ||
-          options.parser === "acorn" ||
-          options.parser === "espree" ||
-          options.parser === "meriyah" ||
-          options.parser === "__babel_estree")))
-  );
+  if (
+    options.parser === "json" ||
+    options.parser === "jsonc" ||
+    !isStringLiteral(node.key) ||
+    // TODO[@fisker]: Use `printString` instead
+    rawText(node.key).slice(1, -1) !== node.key.value
+  ) {
+    return false;
+  }
+
+  // Safe to unquote as identifier
+  if (
+    isEs5IdentifierName(node.key.value) &&
+    // With `--strictPropertyInitialization`, TS treats properties with quoted names differently than unquoted ones.
+    // See https://github.com/microsoft/TypeScript/pull/20075
+    !(
+      (options.parser === "babel-ts" && node.type === "ClassProperty") ||
+      (options.parser === "typescript" && node.type === "PropertyDefinition")
+    )
+  ) {
+    return true;
+  }
+
+  // Safe to unquote as number
+  if (
+    isSimpleNumber(node.key.value) &&
+    String(Number(node.key.value)) === node.key.value &&
+    node.type !== "ImportAttribute" &&
+    (options.parser === "babel" ||
+      options.parser === "acorn" ||
+      options.parser === "espree" ||
+      options.parser === "meriyah" ||
+      options.parser === "__babel_estree")
+  ) {
+    return true;
+  }
+
+  return false;
 }
 
 function shouldQuotePropertyKey(path, options) {