diff --git a/.github/workflows/prod-test.yml b/.github/workflows/prod-test.yml index aacbd4172..1d5760f09 100644 --- a/.github/workflows/prod-test.yml +++ b/.github/workflows/prod-test.yml @@ -92,7 +92,6 @@ jobs: - "16.10.0" - "14" - "12" - - "10" include: - os: "ubuntu-latest" node: "16.10.0" @@ -100,12 +99,8 @@ jobs: exclude: - os: "macos-latest" node: "14" - - os: "macos-latest" - node: "12" - os: "windows-latest" node: "14" - - os: "windows-latest" - node: "12" env: FULL_TEST: ${{ matrix.FULL_TEST }} name: Node.js ${{ matrix.node }} on ${{ matrix.os }} @@ -121,10 +116,6 @@ jobs: node-version: ${{ matrix.node }} cache: "yarn" - - name: Config `ignore-engines=true` (Node.js 10) - if: ${{ matrix.node == '10' }} - run: yarn config set ignore-engines true - - name: Install Dependencies run: yarn install --frozen-lockfile diff --git a/changelog_unreleased/api/11830.md b/changelog_unreleased/api/11830.md new file mode 100644 index 000000000..d6e7036e9 --- /dev/null +++ b/changelog_unreleased/api/11830.md @@ -0,0 +1,3 @@ +#### [Breaking] Drop support for Node.js 10 (#11830 by @fisker) + +The minimal required Node.js version is v12.17.0 diff --git a/scripts/build/build.mjs b/scripts/build/build.mjs index 4b61d71b6..8010bc406 100644 --- a/scripts/build/build.mjs +++ b/scripts/build/build.mjs @@ -126,7 +126,7 @@ function handleError(error) { async function preparePackage() { const packageJson = await readJson(path.join(PROJECT_ROOT, "package.json")); packageJson.bin = "./bin-prettier.js"; - packageJson.engines.node = ">=10.13.0"; + // packageJson.engines.node = ">=10.13.0"; delete packageJson.dependencies; delete packageJson.devDependencies; delete packageJson.browserslist; diff --git a/scripts/build/bundler.mjs b/scripts/build/bundler.mjs index 935d8ff44..d1098758f 100644 --- a/scripts/build/bundler.mjs +++ b/scripts/build/bundler.mjs @@ -84,7 +84,7 @@ function getBabelConfig(bundle) { compact: bundle.type === "plugin" ? false : "auto", exclude: [/\/core-js\//], }; - const targets = { node: "10" }; + const targets = { node: "12" }; if (bundle.target === "universal") { targets.browsers = packageJson.browserslist; } diff --git a/tests/integration/__tests__/early-exit.js b/tests/integration/__tests__/early-exit.js index a23db751a..96296b43e 100644 --- a/tests/integration/__tests__/early-exit.js +++ b/tests/integration/__tests__/early-exit.js @@ -2,7 +2,6 @@ const prettier = require("prettier-local"); const runPrettier = require("../runPrettier.js"); -const { isProduction } = require("../env.js"); describe("show version with --version", () => { runPrettier("cli/with-shebang", ["--version"]).test({ @@ -102,9 +101,7 @@ test("node version error", async () => { const result = runPrettier("cli", ["--help"]); expect(await result.status).toBe(1); expect(await result.stderr).toBe( - `prettier requires at least version ${ - isProduction ? "10.13.0" : "12.17.0" - } of Node, please upgrade\n` + "prettier requires at least version 12.17.0 of Node, please upgrade\n" ); expect(await result.stdout).toBe(""); expect(await result.write).toEqual([]);