From ed8e2056f95640cfac3237e60e1c66b48eb76726 Mon Sep 17 00:00:00 2001 From: fisker Cheung Date: Fri, 26 Sep 2025 18:06:14 +0800 Subject: [PATCH] Minor tweak to `locationForRange` (#17968) --- tests/config/utils/visualize-range.js | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/tests/config/utils/visualize-range.js b/tests/config/utils/visualize-range.js index 220404a1a..579ba0c57 100644 --- a/tests/config/utils/visualize-range.js +++ b/tests/config/utils/visualize-range.js @@ -5,27 +5,22 @@ const codeFrameColumnsOptions = { linesBelow: Number.POSITIVE_INFINITY, }; -const locationForRange = (text, rangeStart, rangeEnd) => { - if (rangeStart > rangeEnd) { - [rangeStart, rangeEnd] = [rangeEnd, rangeStart]; - } +const locationForRange = (text, range) => { + const [start, end] = [...range] + .sort((indexA, indexB) => indexA - indexB) + .map((index) => indexToPosition(text, index, { oneBased: true })); - const start = indexToPosition(text, rangeStart, { oneBased: true }); - const end = indexToPosition(text, rangeEnd, { oneBased: true }); if (start.line !== end.line) { end.column -= 1; } - return { - start, - end, - }; + return { start, end }; }; const visualizeRange = (text, { rangeStart = 0, rangeEnd = text.length }) => codeFrameColumns( text, - locationForRange(text, rangeStart, rangeEnd), + locationForRange(text, [rangeStart, rangeEnd]), rangeStart > rangeEnd ? { ...codeFrameColumnsOptions, message: "[Reversed range]" } : codeFrameColumnsOptions,