From f2caec27f07a8cd6a346b48af5d2d43d0c559d3d Mon Sep 17 00:00:00 2001
From: fisker Cheung <lionkay@gmail.com>
Date: Mon, 14 Mar 2022 10:38:40 +0800
Subject: [PATCH] Fix `umd` plugin

---
 scripts/build/esbuild-plugins/umd.mjs | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/scripts/build/esbuild-plugins/umd.mjs b/scripts/build/esbuild-plugins/umd.mjs
index 3f4531581..4310f1262 100644
--- a/scripts/build/esbuild-plugins/umd.mjs
+++ b/scripts/build/esbuild-plugins/umd.mjs
@@ -58,16 +58,14 @@ function getUmdWrapper({ name, interopDefault = false }, build) {
 
   const [intro, outro] = wrapper.split(placeholder);
 
-  const expectedOutput = `var ${temporaryName}${minify ? "=" : " = "}`;
-
   return {
     name: temporaryName,
     intro,
     outro,
     expectedOutput: {
       start: minify
-        ? `"use strict";var ${temporaryName}=(()=>{`
-        : `"use strict";\nvar ${temporaryName} = (() => {`,
+        ? `var ${temporaryName}=(()=>{`
+        : `var ${temporaryName} = (() => {`,
       end: "})();",
     },
   };
@@ -105,7 +103,12 @@ export default function esbuildPluginUmd(options) {
         if (!fs.existsSync(outfile)) {
           throw new Error(`${outfile} not exists`);
         }
-        const text = fs.readFileSync(outfile, "utf8").trim();
+        let text = fs.readFileSync(outfile, "utf8").trim();
+        // We already insert `"use strict";` in the wrapper
+        if (text.startsWith('"use strict";')) {
+          text = text.slice('"use strict";'.length).trimStart();
+        }
+
         const actualOutput = {
           start: text.slice(0, expectedOutput.start.length),
           end: text.slice(-expectedOutput.end.length),