Simon Lydell
9184743081
* Quote and unquote number keys * Add changelog entry * Add tests for escapes * Fix idempotency * Only run flow-repo/ tests with flow 271 jsfmt.spec.js in flow-repo use only the flow parser. 18 use flow and babel. Now, all of them use only flow. * Don’t unquote negative numbers * Don’t quote/unquote numbers in TypeScript * Quote BigInt * Fix AST check * Fix condition * Fix BigInt to string * Fix ESLint not recognizing BigInt * Only quote/unquote “simple” numbers * No need to clean BigIntLiteral anymore * Add tests for 1. and .1 * Fix 1. and .1 * Remove unnecessary babel-ts from tests * Only unquote numbers for babel * Update changelog
105 lines
2.4 KiB
JavaScript
105 lines
2.4 KiB
JavaScript
const a = {
|
||
a: "a"
|
||
};
|
||
|
||
const b = {
|
||
'b': "b"
|
||
};
|
||
|
||
const b2 = {
|
||
// Escapes should stay as escapes and not be unquoted.
|
||
'\u0062': "b",
|
||
'\u0031': "1"
|
||
};
|
||
|
||
const c = {
|
||
c1: "c1",
|
||
'c2': "c2"
|
||
};
|
||
|
||
const d = {
|
||
d1: "d1",
|
||
'd-2': "d2"
|
||
};
|
||
|
||
// None of these should become quoted, regardless of the quoteProps value.
|
||
const e = {
|
||
NaN: null,
|
||
1: null,
|
||
1.5: null,
|
||
.1: null,
|
||
1.: null,
|
||
1.0: null,
|
||
999999999999999999999: null,
|
||
0.99999999999999999: null,
|
||
1E2: null,
|
||
1e+3: null,
|
||
1e+100: null,
|
||
0b10: null,
|
||
0o10: null,
|
||
0xf: null,
|
||
// Commented out because Flow does not parse BigInt as object keys.
|
||
// 2n: null,
|
||
}
|
||
|
||
const f = {
|
||
// This should be unquoted for quoteProps=as-needed.
|
||
"NaN": null,
|
||
// Flow does parses number keys, but errors on them during type checking so
|
||
// don’t unquote them:
|
||
"1": null,
|
||
"1.5": null,
|
||
// These should never be unquoted. `1e+100` technically could (it’s the only
|
||
// one where `String(Number(key)) === key`), but we came to the conclusion
|
||
// that it is unexpected.
|
||
".1": null,
|
||
"1.": null,
|
||
"1.0": null,
|
||
"999999999999999999999": null,
|
||
"0.99999999999999999": null,
|
||
"1E2": null,
|
||
"1e+3": null,
|
||
"1e+100": null,
|
||
"0b10": null,
|
||
"0o10": null,
|
||
"0xf": null,
|
||
"2n": null,
|
||
}
|
||
|
||
Object.entries({
|
||
// To force quotes for quoteProps=consistent.
|
||
'a-': 'a-',
|
||
// These can be quoted:
|
||
NaN: 'NaN',
|
||
1: '1',
|
||
1.5: '1.5',
|
||
// Prettier will normalize these to `0.1` and `1` – then they can be quoted.
|
||
.1: '.1',
|
||
1.: '1.',
|
||
// These should never be quoted. The _actual_ keys are shown as comments.
|
||
// Copy-paste this into the console to verify. If we were to convert these
|
||
// numbers into decimal (which completely valid), “information/intent” is
|
||
// lost. Either way, writing code like this is super confusing.
|
||
1.0: '1.0', // 1
|
||
999999999999999999999: '999999999999999999999', // 1e+21
|
||
0.99999999999999999: '0.99999999999999999', // 1
|
||
1E2: '1E2', // 100
|
||
1e+3: '1e+3', // 1000
|
||
1e+100: '1e+100', // 1e+100 – this one is identical, but would be inconsistent to quote.
|
||
0b10: '0b10', // 2
|
||
0o10: '0o10', // 8
|
||
0xf: '0xf', // 15
|
||
// Commented out because Flow does not parse BigInt as object keys.
|
||
// 2n: '2n', // 2
|
||
0xb_b: '0xb_b', // 187
|
||
// 0xb_b_bn: '0xb_b_bn', // 3003
|
||
// 0xan: '0xan', // 10
|
||
// 0b100000000000_000000000000000011n: '0b100000000000_000000000000000011n' // 536870915
|
||
})
|
||
|
||
// Negative numbers cannot be unquoted.
|
||
!{
|
||
"-1": null,
|
||
"-1.5": null,
|
||
}
|