MillyandSosuke Suzuki
ca246aface
* Fixed typo * Return early if file does not exist * Added tests for cache * Added `mockWriteFileErrors` option to run helper * Added tests for write error * Remove files with differences from cache * Add `getCliArguments` utility function Refactor * Fix lint * Revert "Fix lint" This reverts commit 18be64b7c42cd669496d59ff64bd534b8e03c3df. * Revert "Add `getCliArguments` utility function" This reverts commit d653fe10a92390102ae97cb43b2efcbb5c3c9140. * Refactor with `cliArguments` variable Co-authored-by: Sosuke Suzuki <sosuke.suzuki@dr-ubie.com>
609 lines
19 KiB
JavaScript
609 lines
19 KiB
JavaScript
"use strict";
|
|
|
|
const path = require("path");
|
|
const { promises: fs } = require("fs");
|
|
const rimraf = require("rimraf");
|
|
const { default: stripAnsi } = require("../../../vendors/strip-ansi.js");
|
|
|
|
const runPrettier = require("../run-prettier.js");
|
|
|
|
function resolveDir(dir) {
|
|
return path.join(__dirname, "..", dir);
|
|
}
|
|
|
|
describe("--cache option", () => {
|
|
const dir = resolveDir("cli/cache");
|
|
const defaultCacheFile = path.join(
|
|
dir,
|
|
"node_modules/.cache/prettier/.prettier-cache"
|
|
);
|
|
|
|
const nonDefaultCacheFileName = ".non-default-cache-file";
|
|
const nonDefaultCacheFilePath = path.join(dir, nonDefaultCacheFileName);
|
|
|
|
let contentA;
|
|
let contentB;
|
|
|
|
beforeAll(async () => {
|
|
contentA = await fs.readFile(path.join(dir, "a.js"), "utf8");
|
|
contentB = await fs.readFile(path.join(dir, "b.js"), "utf8");
|
|
});
|
|
|
|
afterEach(async () => {
|
|
rimraf.sync(path.join(dir, "node_modules"));
|
|
rimraf.sync(nonDefaultCacheFilePath);
|
|
await fs.writeFile(path.join(dir, "a.js"), contentA);
|
|
await fs.writeFile(path.join(dir, "b.js"), contentB);
|
|
});
|
|
|
|
it("throw error when cache-strategy is invalid", async () => {
|
|
const { stderr } = await runPrettier(dir, [
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"invalid",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(stderr.trim())).toBe(
|
|
'[error] Invalid --cache-strategy value. Expected "content" or "metadata", but received "invalid".'
|
|
);
|
|
});
|
|
|
|
it("throws error when use with --stdin-filepath", async () => {
|
|
const { stderr } = await runPrettier(
|
|
dir,
|
|
["--cache", "--stdin-filepath", "foo.js"],
|
|
{ input: "const a = a;" }
|
|
);
|
|
expect(stripAnsi(stderr.trim())).toBe(
|
|
"[error] `--cache` cannot be used with stdin."
|
|
);
|
|
});
|
|
|
|
it("throws error when use `--cache-strategy` without `--cache`.", async () => {
|
|
const { stderr } = await runPrettier(
|
|
dir,
|
|
["foo.js", "--cache-strategy", "content"],
|
|
{
|
|
input: "const a = a;",
|
|
}
|
|
);
|
|
expect(stripAnsi(stderr.trim())).toBe(
|
|
"[error] `--cache-strategy` cannot be used without `--cache`."
|
|
);
|
|
});
|
|
|
|
it("throws error when `--cache-location` is a directory.", async () => {
|
|
const { stderr } = await runPrettier(dir, [
|
|
"foo.js",
|
|
"--cache",
|
|
"--cache-location",
|
|
"dir",
|
|
]);
|
|
expect(stripAnsi(stderr.trim())).toEqual(
|
|
expect.stringMatching(
|
|
/\[error] Resolved --cache-location '.+' is a directory/
|
|
)
|
|
);
|
|
});
|
|
|
|
describe("--cache-strategy metadata", () => {
|
|
it("creates default cache file named `node_modules/.cache/prettier/.prettier-cache`", async () => {
|
|
await expect(fs.stat(defaultCacheFile)).rejects.toHaveProperty(
|
|
"code",
|
|
"ENOENT"
|
|
);
|
|
await runPrettier(dir, ["--cache", "--cache-strategy", "metadata", "."]);
|
|
await expect(fs.stat(defaultCacheFile)).resolves.not.toThrowError();
|
|
});
|
|
|
|
it("doesn't format when cache is available", async () => {
|
|
const { stdout: firstStdout } = await runPrettier(dir, [
|
|
"--cache",
|
|
"--write",
|
|
"--cache-strategy",
|
|
"metadata",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(firstStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, [
|
|
"--cache",
|
|
"--write",
|
|
"--cache-strategy",
|
|
"metadata",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms \(cached\)$/),
|
|
expect.stringMatching(/^b\.js .+ms \(cached\)$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("re-formats when a file has been updated.", async () => {
|
|
const cliArguments = [
|
|
"--cache",
|
|
"--write",
|
|
"--cache-strategy",
|
|
"metadata",
|
|
".",
|
|
];
|
|
const { stdout: firstStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(firstStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
|
|
// Update `a.js`
|
|
await fs.writeFile(path.join(dir, "a.js"), "const a = `a`;");
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual(
|
|
// the cache of `b.js` is only available.
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms \(cached\)$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("re-formats when timestamp has been updated", async () => {
|
|
const cliArguments = [
|
|
"--cache",
|
|
"--write",
|
|
"--cache-strategy",
|
|
"metadata",
|
|
".",
|
|
];
|
|
const { stdout: firstStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(firstStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
|
|
// update timestamp
|
|
const time = new Date();
|
|
await fs.utimes(path.join(dir, "a.js"), time, time);
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual(
|
|
// the cache of `b.js` is only available.
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms \(cached\)$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("re-formats when options has been updated.", async () => {
|
|
const { stdout: firstStdout } = await runPrettier(dir, [
|
|
"--cache",
|
|
"--write",
|
|
"--cache-strategy",
|
|
"metadata",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(firstStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, [
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"metadata",
|
|
"--write",
|
|
"--trailing-comma",
|
|
"all",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("re-formats after execution without write.", async () => {
|
|
await runPrettier(dir, ["--cache", "--cache-strategy", "metadata", "."]);
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, [
|
|
"--write",
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"metadata",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms \(cached\)$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("re-formats when multiple cached files are updated.", async () => {
|
|
const cliArguments = [
|
|
"--write",
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"metadata",
|
|
".",
|
|
];
|
|
await runPrettier(dir, cliArguments);
|
|
|
|
// Update `a.js` to unformatted
|
|
await fs.writeFile(path.join(dir, "a.js"), "const a = `a`; ");
|
|
|
|
// Update `b.js` but still formatted
|
|
const time = new Date();
|
|
await fs.utimes(path.join(dir, "b.js"), time, time);
|
|
|
|
await runPrettier(dir, ["--cache", "--cache-strategy", "metadata", "."]);
|
|
|
|
const { stdout: thirdStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(thirdStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms \(cached\)$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("doesn't cache files when write error.", async () => {
|
|
const {
|
|
stdout: firstStdout,
|
|
stderr: firstStderr,
|
|
status: firstStatus,
|
|
} = await runPrettier(
|
|
dir,
|
|
["--write", "--cache", "--cache-strategy", "metadata", "."],
|
|
{
|
|
mockWriteFileErrors: {
|
|
"a.js": "EACCES: permission denied (mock error)",
|
|
},
|
|
}
|
|
);
|
|
expect(firstStatus).toBe(2);
|
|
expect(stripAnsi(firstStderr).split("\n").filter(Boolean)).toEqual([
|
|
"[error] Unable to write file: a.js",
|
|
"[error] EACCES: permission denied (mock error)",
|
|
]);
|
|
expect(stripAnsi(firstStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, [
|
|
"--list-different",
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"metadata",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual([
|
|
"a.js",
|
|
]);
|
|
});
|
|
|
|
it("removes cache file when run Prettier without `--cache` option", async () => {
|
|
await runPrettier(dir, [
|
|
"--cache",
|
|
"--write",
|
|
"--cache-strategy",
|
|
"metadata",
|
|
".",
|
|
]);
|
|
await expect(fs.stat(defaultCacheFile)).resolves.not.toThrowError();
|
|
await runPrettier(dir, ["--write", "."]);
|
|
await expect(fs.stat(defaultCacheFile)).rejects.toThrowError();
|
|
});
|
|
});
|
|
|
|
describe("--cache-strategy content", () => {
|
|
it("creates default cache file named `node_modules/.cache/prettier/.prettier-cache`", async () => {
|
|
await expect(fs.stat(defaultCacheFile)).rejects.toHaveProperty(
|
|
"code",
|
|
"ENOENT"
|
|
);
|
|
await runPrettier(dir, ["--cache", "--cache-strategy", "content", "."]);
|
|
await expect(fs.stat(defaultCacheFile)).resolves.not.toThrowError();
|
|
});
|
|
|
|
it("doesn't format when cache is available", async () => {
|
|
const cliArguments = [
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"content",
|
|
"--write",
|
|
".",
|
|
];
|
|
const { stdout: firstStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(firstStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms \(cached\)$/),
|
|
expect.stringMatching(/^b\.js .+ms \(cached\)$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("re-formats when a file has been updated.", async () => {
|
|
const cliArguments = [
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"content",
|
|
"--write",
|
|
".",
|
|
];
|
|
const { stdout: firstStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(firstStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
|
|
// Update `a.js`
|
|
await fs.writeFile(path.join(dir, "a.js"), "const a = `a`;");
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual(
|
|
// the cache of `b.js` is only available.
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms \(cached\)$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("doesn't re-format when timestamp has been updated", async () => {
|
|
const cliArguments = [
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"content",
|
|
"--write",
|
|
".",
|
|
];
|
|
const { stdout: firstStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(firstStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
|
|
// update timestamp
|
|
const time = new Date();
|
|
await fs.utimes(path.join(dir, "a.js"), time, time);
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms \(cached\)$/),
|
|
expect.stringMatching(/^b\.js .+ms \(cached\)$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("re-formats when options has been updated.", async () => {
|
|
const { stdout: firstStdout } = await runPrettier(dir, [
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"content",
|
|
"--write",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(firstStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, [
|
|
"--cache",
|
|
"--write",
|
|
"--cache-strategy",
|
|
"content",
|
|
"--trailing-comma",
|
|
"all",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("re-formats after execution without write.", async () => {
|
|
await runPrettier(dir, ["--cache", "--cache-strategy", "content", "."]);
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, [
|
|
"--write",
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"content",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms \(cached\)$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("re-formats when multiple cached files are updated.", async () => {
|
|
const cliArguments = [
|
|
"--write",
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"content",
|
|
".",
|
|
];
|
|
await runPrettier(dir, cliArguments);
|
|
|
|
// Update `a.js` to unformatted
|
|
await fs.writeFile(path.join(dir, "a.js"), "const a = `a`; ");
|
|
|
|
// Update `b.js` but still formatted
|
|
const time = new Date();
|
|
await fs.utimes(path.join(dir, "b.js"), time, time);
|
|
|
|
await runPrettier(dir, ["--cache", "--cache-strategy", "content", "."]);
|
|
|
|
const { stdout: thirdStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(thirdStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms \(cached\)$/),
|
|
])
|
|
);
|
|
});
|
|
|
|
it("doesn't cache files when write error.", async () => {
|
|
const {
|
|
stdout: firstStdout,
|
|
stderr: firstStderr,
|
|
status: firstStatus,
|
|
} = await runPrettier(
|
|
dir,
|
|
["--write", "--cache", "--cache-strategy", "content", "."],
|
|
{
|
|
mockWriteFileErrors: {
|
|
"a.js": "EACCES: permission denied (mock error)",
|
|
},
|
|
}
|
|
);
|
|
expect(firstStatus).toBe(2);
|
|
expect(stripAnsi(firstStderr).split("\n").filter(Boolean)).toEqual([
|
|
"[error] Unable to write file: a.js",
|
|
"[error] EACCES: permission denied (mock error)",
|
|
]);
|
|
expect(stripAnsi(firstStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, [
|
|
"--list-different",
|
|
"--cache",
|
|
"--cache-strategy",
|
|
"content",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual([
|
|
"a.js",
|
|
]);
|
|
});
|
|
|
|
it("removes cache file when run Prettier without `--cache` option", async () => {
|
|
await runPrettier(dir, ["--cache", "--write", "."]);
|
|
await expect(fs.stat(defaultCacheFile)).resolves.not.toThrowError();
|
|
await runPrettier(dir, ["--write", "."]);
|
|
await expect(fs.stat(defaultCacheFile)).rejects.toThrowError();
|
|
});
|
|
});
|
|
|
|
describe("--cache-location", () => {
|
|
it("doesn't create default cache file when `--cache-location` exists", async () => {
|
|
await expect(fs.stat(defaultCacheFile)).rejects.toHaveProperty(
|
|
"code",
|
|
"ENOENT"
|
|
);
|
|
await runPrettier(dir, [
|
|
"--cache",
|
|
"--cache-location",
|
|
nonDefaultCacheFileName,
|
|
".",
|
|
]);
|
|
await expect(fs.stat(defaultCacheFile)).rejects.toHaveProperty(
|
|
"code",
|
|
"ENOENT"
|
|
);
|
|
});
|
|
|
|
it("throws error for invalid JSON file", async () => {
|
|
const { stderr } = await runPrettier(dir, [
|
|
"--cache",
|
|
"--cache-location",
|
|
"a.js",
|
|
".",
|
|
]);
|
|
expect(stripAnsi(stderr).trim()).toEqual(
|
|
expect.stringMatching(/\[error] '.+' isn't a valid JSON file/)
|
|
);
|
|
});
|
|
|
|
describe("file", () => {
|
|
it("creates the cache file at location specified by `--cache-location`", async () => {
|
|
await expect(fs.stat(nonDefaultCacheFilePath)).rejects.toHaveProperty(
|
|
"code",
|
|
"ENOENT"
|
|
);
|
|
await runPrettier(dir, [
|
|
"--cache",
|
|
"--cache-location",
|
|
nonDefaultCacheFileName,
|
|
".",
|
|
]);
|
|
await expect(
|
|
fs.stat(nonDefaultCacheFilePath)
|
|
).resolves.not.toThrowError();
|
|
});
|
|
|
|
it("does'nt format when cache is available", async () => {
|
|
const cliArguments = [
|
|
"--cache",
|
|
"--write",
|
|
"--cache-location",
|
|
nonDefaultCacheFileName,
|
|
".",
|
|
];
|
|
const { stdout: firstStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(firstStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms$/),
|
|
expect.stringMatching(/^b\.js .+ms$/),
|
|
])
|
|
);
|
|
|
|
const { stdout: secondStdout } = await runPrettier(dir, cliArguments);
|
|
expect(stripAnsi(secondStdout).split("\n").filter(Boolean)).toEqual(
|
|
expect.arrayContaining([
|
|
expect.stringMatching(/^a\.js .+ms \(cached\)$/),
|
|
expect.stringMatching(/^b\.js .+ms \(cached\)$/),
|
|
])
|
|
);
|
|
});
|
|
});
|
|
});
|
|
});
|