testea/test-repo
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix union type in FunctionTypeParam without name (#19397)

Browse Source 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This commit is contained in:
fisker Cheungandautofix-ci[bot] authored and GitHub committed 2026-06-17 21:20:49 +08:00
1 parent 8dd5cc2d02
commit 3751f82fc6
7 files changed
+221 -13
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/language-js/print/union-type.js
+5 -1
View File
@@ -97,7 +97,11 @@ function shouldIndentUnionType(path) {
(key === "elementTypes" && isTupleType(parent)) ||
((key === "trueType" || key === "falseType") &&
isConditionalType(parent)) ||
(key === "params" && isTypeParameterInstantiation(parent))
(key === "params" && isTypeParameterInstantiation(parent)) ||
(key === "typeAnnotation" &&
parent.type === "FunctionTypeParam" &&
!parent.name &&
path.grandparent.this !== parent)
) {
return false;
}
tests/format/flow/this-annotation/__snapshots__/format.test.js.snap
+30 -8
View File
@@ -176,32 +176,54 @@ trailingComma: "all"
=====================================input======================================
// @flow
type A = (
this: | SupperLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
type A1 = (
this: | SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
b: number,
) => boolean;
type B = (
_this: | SupperLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
type A2 = (
_this: | SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
b: number,
) => boolean
type A3 = (
| SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
b: number,
) => boolean
type A4 = (
/* this: */ | SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
b: number,
) => boolean
=====================================output=====================================
// @flow
type A = (
type A1 = (
this:
| SupperLongLongLongLongLongLongLongLongLongLongLongType
| SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType
| FooBarBazLorem12345,
b: number,
) => boolean;
type B = (
type A2 = (
_this:
| SupperLongLongLongLongLongLongLongLongLongLongLongType
| SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType
| FooBarBazLorem12345,
b: number,
) => boolean;
type A3 = (
| SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType
| FooBarBazLorem12345,
b: number,
) => boolean;
type A4 = (
/* this: */ | SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType
| FooBarBazLorem12345,
b: number,
) => boolean;
================================================================================
`;
tests/format/flow/this-annotation/union_type.js
+14 -4
View File
@@ -1,11 +1,21 @@
// @flow
type A = (
this: | SupperLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
type A1 = (
this: | SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
b: number,
) => boolean;
type B = (
_this: | SupperLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
type A2 = (
_this: | SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
b: number,
) => boolean
type A3 = (
| SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
b: number,
) => boolean
type A4 = (
/* this: */ | SupperLongLongLongLongLongLongLongLongLongLongLongLongLongType | FooBarBazLorem12345,
b: number,
) => boolean
tests/format/flow/union/__snapshots__/format.test.js.snap
+79
View File
@@ -22,6 +22,85 @@ const myValue = (callcallcallcallcallcall(
================================================================================
`;
exports[`function-type-param.js format 1`] = `
====================================options=====================================
parsers: ["flow"]
printWidth: 80 (default) |
=====================================input======================================
type a1 = (
| {//
}
| {//
},
) => void
type a2 = (
// Comment
| {//
}
| {//
},
) => void
hook useRefetchFunction(
dispatch: (
| {
environment: IEnvironment,
fragmentIdentifier: string,
type: 'reset',
}
| {
fetchPolicy?: FetchPolicy,
onComplete?: (Error | null) => void,
refetchEnvironment: ?IEnvironment,
refetchQuery: OperationDescriptor,
renderPolicy?: RenderPolicy,
type: 'refetch',
},
) => void,
) {}
=====================================output=====================================
type a1 = (
| {
//
}
| {
//
},
) => void;
type a2 = (
// Comment
| {
//
}
| {
//
},
) => void;
hook useRefetchFunction(
dispatch: (
| {
environment: IEnvironment,
fragmentIdentifier: string,
type: "reset",
}
| {
fetchPolicy?: FetchPolicy,
onComplete?: (Error | null) => void,
refetchEnvironment: ?IEnvironment,
refetchQuery: OperationDescriptor,
renderPolicy?: RenderPolicy,
type: "refetch",
},
) => void,
) {}
================================================================================
`;
exports[`issue-1197-2.js format 1`] = `
====================================options=====================================
parsers: ["flow"]
tests/format/flow/union/function-type-param.js
+32
View File
@@ -0,0 +1,32 @@
type a1 = (
| {//
}
| {//
},
) => void
type a2 = (
// Comment
| {//
}
| {//
},
) => void
hook useRefetchFunction(
dispatch: (
| {
environment: IEnvironment,
fragmentIdentifier: string,
type: 'reset',
}
| {
fetchPolicy?: FetchPolicy,
onComplete?: (Error | null) => void,
refetchEnvironment: ?IEnvironment,
refetchQuery: OperationDescriptor,
renderPolicy?: RenderPolicy,
type: 'refetch',
},
) => void,
) {}
tests/format/typescript/union/consistent-with-flow/__snapshots__/format.test.js.snap
+46
View File
@@ -257,6 +257,52 @@ type A = T extends "arrow"
================================================================================
`;
exports[`function-type-param.ts format 1`] = `
====================================options=====================================
parsers: ["typescript", "flow"]
printWidth: 80 (default) |
=====================================input======================================
type a1 = (
a: | {//
}
| {//
},
) => void
type a2 = (
a:
// Comment
| {//
}
| {//
},
) => void
=====================================output=====================================
type a1 = (
a:
| {
//
}
| {
//
},
) => void;
type a2 = (
a:
// Comment
| {
//
}
| {
//
},
) => void;
================================================================================
`;
exports[`in-tuple.ts format 1`] = `
====================================options=====================================
parsers: ["typescript", "flow"]
tests/format/typescript/union/consistent-with-flow/function-type-param.ts
+15
View File
@@ -0,0 +1,15 @@
type a1 = (
a: | {//
}
| {//
},
) => void
type a2 = (
a:
// Comment
| {//
}
| {//
},
) => void