Style: Remove useless flags (#10861)

.eslintrc.yml

@@ -6,9 +6,10 @@ extends:
   - eslint:recommended
   - prettier
 plugins:
-  - import
-  - unicorn
   - prettier-internal-rules
+  - import
+  - regexp
+  - unicorn
 settings:
   import/internal-regex: ^linguist-languages/
 rules:
@@ -69,6 +70,7 @@ rules:
     - error
     - never
     - exceptRange: true
+  regexp/no-useless-flag: error
   unicorn/better-regex: error
   unicorn/explicit-length-check: error
   unicorn/new-for-builtins: error

package.json

@@ -113,6 +113,7 @@
     "eslint-plugin-jest": "24.3.6",
     "eslint-plugin-prettier-internal-rules": "link:scripts/tools/eslint-plugin-prettier-internal-rules",
     "eslint-plugin-react": "7.23.2",
+    "eslint-plugin-regexp": "0.10.0",
     "eslint-plugin-unicorn": "31.0.0",
     "execa": "5.0.0",
     "jest": "26.6.3",

src/document/doc-utils.js

@@ -390,7 +390,7 @@ function normalizeDoc(doc) {
 function replaceNewlinesWithLiterallines(doc) {
   return mapDoc(doc, (currentDoc) =>
     typeof currentDoc === "string" && currentDoc.includes("\n")
-      ? currentDoc.split(/(\n)/g).map((v, i) => (i % 2 === 0 ? v : literalline))
+      ? currentDoc.split(/(\n)/).map((v, i) => (i % 2 === 0 ? v : literalline))
       : currentDoc
   );
 }

src/language-css/printer-postcss.js

@@ -348,7 +348,7 @@ function genericPrint(path, options, print) {
     }
     case "media-url": {
       return adjustStrings(
-        node.value.replace(/^url\(\s+/gi, "url(").replace(/\s+\)$/gi, ")"),
+        node.value.replace(/^url\(\s+/gi, "url(").replace(/\s+\)$/g, ")"),
         options
       );
     }

src/language-js/printer-estree.js

@@ -9,7 +9,8 @@ const assert = require("assert");
 const { printDanglingComments } = require("../main/comments");
 const { hasNewline, printString, printNumber } = require("../common/util");
 const {
-  builders: { join, line, hardline, softline, literalline, group, indent },
+  builders: { join, line, hardline, softline, group, indent },
+  utils: { replaceNewlinesWithLiterallines },
 } = require("../document");
 const embed = require("./embed");
 const clean = require("./clean");
@@ -749,7 +750,7 @@ function printPathNoParens(path, options, print, args) {
     case "ClassPrivateProperty":
       return printClassProperty(path, options, print);
     case "TemplateElement":
-      return join(literalline, node.value.raw.split(/\r?\n/g));
+      return replaceNewlinesWithLiterallines(node.value.raw);
     case "TemplateLiteral":
       return printTemplateLiteral(path, print, options);
     case "TaggedTemplateExpression":

src/language-yaml/utils.js

@@ -164,7 +164,7 @@ function splitWithSingleSpace(text) {
   const parts = [];
 
   let lastPart;
-  for (const part of text.split(/( +)/g)) {
+  for (const part of text.split(/( +)/)) {
     /* istanbul ignore else */
     if (part !== " ") {
       if (lastPart === " ") {

yarn.lock

@@ -2533,6 +2533,11 @@ comment-json@^4.0.6, comment-json@^4.1.0:
     has-own-prop "^2.0.0"
     repeat-string "^1.6.1"
 
+comment-parser@^1.1.2:
+  version "1.1.5"
+  resolved "https://registry.yarnpkg.com/comment-parser/-/comment-parser-1.1.5.tgz#453627ef8f67dbcec44e79a9bd5baa37f0bce9b2"
+  integrity sha512-RePCE4leIhBlmrqiYTvaqEeGYg7qpSl4etaIabKtdOQVi+mSTIBBklGUwIr79GXYnl3LpMwmDw4KeR2stNc6FA==
+
 commondir@^1.0.1:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/commondir/-/commondir-1.0.1.tgz#ddd800da0c66127393cca5950ea968a3aaf1253b"
@@ -3139,6 +3144,18 @@ eslint-plugin-react@7.23.2:
     resolve "^2.0.0-next.3"
     string.prototype.matchall "^4.0.4"
 
+eslint-plugin-regexp@0.10.0:
+  version "0.10.0"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-regexp/-/eslint-plugin-regexp-0.10.0.tgz#5391e21d805bce53b6846446fe4aed7961f33b62"
+  integrity sha512-KwIdNUnwz9CFZ1jApWZ++Y1cVWbJBYdJHMDh7KNe9HpElSwHGZHtX1QaHq3Iv2nMYJitGIE6JdkYbfzm9BzPQw==
+  dependencies:
+    comment-parser "^1.1.2"
+    eslint-utils "^2.1.0"
+    jsdoctypeparser "^9.0.0"
+    refa "^0.8.0"
+    regexp-ast-analysis "^0.2.0"
+    regexpp "^3.1.0"
+
 eslint-plugin-unicorn@31.0.0:
   version "31.0.0"
   resolved "https://registry.yarnpkg.com/eslint-plugin-unicorn/-/eslint-plugin-unicorn-31.0.0.tgz#53eef3f5152ddaa531888f77a420313e30d9864a"
@@ -4734,6 +4751,11 @@ jsbn@~0.1.0:
   resolved "https://registry.yarnpkg.com/jsbn/-/jsbn-0.1.1.tgz#a5e654c2e5a2deb5f201d96cefbca80c0ef2f513"
   integrity sha1-peZUwuWi3rXyAdls77yoDA7y9RM=
 
+jsdoctypeparser@^9.0.0:
+  version "9.0.0"
+  resolved "https://registry.yarnpkg.com/jsdoctypeparser/-/jsdoctypeparser-9.0.0.tgz#8c97e2fb69315eb274b0f01377eaa5c940bd7b26"
+  integrity sha512-jrTA2jJIL6/DAEILBEh2/w9QxCuwmvNXIry39Ay/HVfhE3o2yVV0U44blYkqdHA/OKloJEqvJy0xU+GSdE2SIw==
+
 jsdom@^16.4.0:
   version "16.4.0"
   resolved "https://registry.yarnpkg.com/jsdom/-/jsdom-16.4.0.tgz#36005bde2d136f73eee1a830c6d45e55408edddb"
@@ -5853,6 +5875,13 @@ rechoir@^0.6.2:
   dependencies:
     resolve "^1.1.6"
 
+refa@^0.8.0:
+  version "0.8.0"
+  resolved "https://registry.yarnpkg.com/refa/-/refa-0.8.0.tgz#81813b0ac80fd6e2d79f191e31054f210ef80a53"
+  integrity sha512-qOf9zk1McAuGPtQ16nzuWCUg9zx3Quc48i6oD6nxWJdrFeh3Do0vCpIGYLij/1ysAbh5rxdUNg+YzSVBRycX5g==
+  dependencies:
+    regexpp "^3.1.0"
+
 regenerate-unicode-properties@^8.2.0:
   version "8.2.0"
   resolved "https://registry.yarnpkg.com/regenerate-unicode-properties/-/regenerate-unicode-properties-8.2.0.tgz#e5de7111d655e7ba60c057dbe9ff37c87e65cdec"
@@ -5885,6 +5914,14 @@ regex-not@^1.0.0, regex-not@^1.0.2:
     extend-shallow "^3.0.2"
     safe-regex "^1.1.0"
 
+regexp-ast-analysis@^0.2.0:
+  version "0.2.0"
+  resolved "https://registry.yarnpkg.com/regexp-ast-analysis/-/regexp-ast-analysis-0.2.0.tgz#2d676024539dc11a0d99d0ddf861d818ba20a1b5"
+  integrity sha512-ZVNwBF65Gn4CbRdPNYle8NAPFSDbbJ83svYUk4Mpqmr1QTUx2M06my9x7o8Hw/oFXDwXrJo/7W+ijLfFM5oG2Q==
+  dependencies:
+    refa "^0.8.0"
+    regexpp "^3.1.0"
+
 regexp-tree@^0.1.23, regexp-tree@~0.1.1:
   version "0.1.23"
   resolved "https://registry.yarnpkg.com/regexp-tree/-/regexp-tree-0.1.23.tgz#8a8ce1cc5e971acef62213a7ecdb1f6e18a1f1b2"