Use node: protocol (#12373)

.eslintrc.cjs

@@ -187,13 +187,6 @@ module.exports = {
         "unicorn/prefer-module": "off",
       },
     },
-    // `esbuild` don't support
-    {
-      files: ["bin/**/*.js", "src/**/*.js"],
-      rules: {
-        "unicorn/prefer-node-protocol": "off",
-      },
-    },
     {
       files: [
         "tests/format/**/jsfmt.spec.js",

scripts/build/bundler.mjs

@@ -11,6 +11,7 @@ import esbuildPluginLicense from "./esbuild-plugins/license.mjs";
 import esbuildPluginUmd from "./esbuild-plugins/umd.mjs";
 import esbuildPluginInteropDefault from "./esbuild-plugins/interop-default.mjs";
 import esbuildPluginVisualizer from "./esbuild-plugins/visualizer.mjs";
+import esbuildPluginStripNodeProtocol from "./esbuild-plugins/strip-node-protocol.mjs";
 import bundles from "./config.mjs";
 
 const { __dirname, readJsonSync, require } = createEsmUtils(import.meta);
@@ -121,6 +122,7 @@ function* getEsbuildOptions(bundle, buildOptions) {
     metafile: true,
     plugins: [
       esbuildPluginEvaluate(),
+      esbuildPluginStripNodeProtocol(),
       esbuildPluginReplaceModule({ ...replaceModule, ...bundle.replaceModule }),
       bundle.target === "universal" && esbuildPluginNodeModulePolyfills(),
       esbuildPluginTextReplace({

scripts/build/esbuild-plugins/strip-node-protocol.mjs

@@ -0,0 +1,10 @@
+export default function esbuildPluginStripNodeProtocol() {
+  return {
+    name: "strip-node-protocol",
+    setup(build) {
+      build.onResolve({ filter: /^node:/ }, ({ path }) =>
+        build.resolve(path.slice(5))
+      );
+    },
+  };
+}

src/cli/expand-patterns.js

@@ -1,5 +1,5 @@
-import path from "path";
-import { promises as fs } from "fs";
+import path from "node:path";
+import { promises as fs } from "node:fs";
 import fastGlob from "fast-glob";
 
 /** @typedef {import('./context').Context} Context */

src/cli/find-config-path.js

@@ -1,4 +1,4 @@
-import path from "path";
+import path from "node:path";
 import prettier from "../index.js";
 
 async function logResolvedConfigPathOrDie(context) {

src/cli/format.js

@@ -1,5 +1,5 @@
-import { promises as fs } from "fs";
-import path from "path";
+import { promises as fs } from "node:fs";
+import path from "node:path";
 import chalk from "chalk";
 import prettier from "../index.js";
 import thirdParty from "../common/third-party.cjs";

src/cli/logger.js

@@ -1,4 +1,4 @@
-import readline from "readline";
+import readline from "node:readline";
 import chalk from "chalk";
 import stripAnsi from "strip-ansi";
 import wcwidth from "wcwidth";

src/common/create-ignorer.js

@@ -1,4 +1,4 @@
-import path from "path";
+import path from "node:path";
 import ignore from "ignore";
 import getFileContentOrNull from "../utils/get-file-content-or-null.js";
 

src/common/get-file-info.js

@@ -1,4 +1,4 @@
-import path from "path";
+import path from "node:path";
 import { inferParser } from "../main/options.js";
 import * as config from "../config/resolve-config.js";
 import createIgnorer from "./create-ignorer.js";

src/common/load-plugins.js

@@ -1,7 +1,7 @@
-import { createRequire } from "module";
-import fs from "fs";
-import path from "path";
-import { fileURLToPath } from "url";
+import { createRequire } from "node:module";
+import fs from "node:fs";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
 import { uniqBy, partition } from "lodash-es";
 import fastGlob from "fast-glob";
 import mem, { memClear } from "mem";

src/common/resolve.js

@@ -1,4 +1,4 @@
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 
 const require = createRequire(import.meta.url);
 

src/config/find-project-root.js

@@ -1,8 +1,8 @@
 // Simple version of `find-project-root`
 // https://github.com/kirstein/find-project-root/blob/master/index.js
 
-import fs from "fs";
-import path from "path";
+import fs from "node:fs";
+import path from "node:path";
 
 const MARKERS = [".git", ".hg"];
 

src/config/resolve-config-editorconfig.js

@@ -1,4 +1,4 @@
-import path from "path";
+import path from "node:path";
 
 import editorconfig from "editorconfig";
 import editorConfigToPrettier from "editorconfig-to-prettier";

src/config/resolve-config.js

@@ -1,5 +1,5 @@
-import { createRequire } from "module";
-import path from "path";
+import { createRequire } from "node:module";
+import path from "node:path";
 import micromatch from "micromatch";
 import mem, { memClear } from "mem";
 import thirdParty from "../common/third-party.cjs";

src/index.js

@@ -1,4 +1,4 @@
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 import core from "./main/core.js";
 import { getSupportInfo } from "./main/support.js";
 import getFileInfo from "./common/get-file-info.js";

src/language-css/index.js

@@ -1,4 +1,4 @@
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 import createLanguage from "../utils/create-language.js";
 import printer from "./printer-postcss.js";
 import options from "./options.js";

src/language-graphql/index.js

@@ -1,4 +1,4 @@
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 import createLanguage from "../utils/create-language.js";
 import printer from "./printer-graphql.js";
 import options from "./options.js";

src/language-handlebars/index.js

@@ -1,4 +1,4 @@
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 import createLanguage from "../utils/create-language.js";
 import printer from "./printer-glimmer.js";
 import parsers from "./parsers.js";

src/language-html/index.js

@@ -1,4 +1,4 @@
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 import createLanguage from "../utils/create-language.js";
 import printer from "./printer-html.js";
 import options from "./options.js";

src/language-html/print/tag.js

@@ -2,7 +2,7 @@
  * @typedef {import("../../document").Doc} Doc
  */
 
-import assert from "assert";
+import assert from "node:assert";
 import { isNonEmptyArray } from "../../common/util.js";
 import doc from "../../document/index.js";
 import { locStart, locEnd } from "../loc.js";

src/language-js/index.js

@@ -1,4 +1,4 @@
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 import createLanguage from "../utils/create-language.js";
 import estreePrinter from "./printer-estree.js";
 import estreeJsonPrinter from "./printer-estree-json.js";

src/language-js/print/flow.js

@@ -1,6 +1,6 @@
 /** @typedef {import("../../document").Doc} Doc */
 
-import assert from "assert";
+import assert from "node:assert";
 import { printDanglingComments } from "../../main/comments.js";
 import { printString, printNumber } from "../../common/util.js";
 import doc from "../../document/index.js";

src/language-js/print/function.js

@@ -1,6 +1,6 @@
 /** @typedef {import("../../document/doc-builders").Doc} Doc */
 
-import assert from "assert";
+import assert from "node:assert";
 import {
   printDanglingComments,
   printCommentsSeparately,

src/language-markdown/index.js

@@ -1,4 +1,4 @@
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 import createLanguage from "../utils/create-language.js";
 import printer from "./printer-markdown.js";
 import options from "./options.js";

src/language-yaml/index.js

@@ -1,4 +1,4 @@
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 import createLanguage from "../utils/create-language.js";
 import printer from "./printer-yaml.js";
 import options from "./options.js";

src/main/comments.js

@@ -1,4 +1,4 @@
-import assert from "assert";
+import assert from "node:assert";
 
 import doc from "../document/index.js";
 

src/main/options.js

@@ -1,4 +1,4 @@
-import path from "path";
+import path from "node:path";
 import { UndefinedParserError } from "../common/errors.js";
 import { getSupportInfo } from "../main/support.js";
 import getInterpreter from "../utils/get-interpreter.js";

src/main/parser.js

@@ -1,5 +1,5 @@
-import { createRequire } from "module";
-import path from "path";
+import { createRequire } from "node:module";
+import path from "node:path";
 import { ConfigError } from "../common/errors.js";
 import { locStart, locEnd } from "../language-js/loc.js";
 

src/main/range-util.js

@@ -1,4 +1,4 @@
-import assert from "assert";
+import assert from "node:assert";
 import { getSortedChildNodes } from "./comments.js";
 
 const isJsonParser = ({ parser }) =>

src/main/support.js

@@ -1,4 +1,4 @@
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 import semverCompare from "semver/functions/compare.js";
 import semverGte from "semver/functions/gte.js";
 import semverLt from "semver/functions/lt.js";

src/standalone.js

@@ -1,4 +1,4 @@
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 import core from "./main/core.js";
 import { getSupportInfo } from "./main/support.js";
 import * as sharedUtil from "./common/util-shared.js";

src/utils/get-file-content-or-null.js

@@ -1,4 +1,4 @@
-import fs from "fs";
+import fs from "node:fs";
 const fsAsync = fs.promises;
 
 /**

src/utils/get-interpreter.js

@@ -1,4 +1,4 @@
-import fs from "fs";
+import fs from "node:fs";
 import readlines from "n-readlines";
 
 function getInterpreter(filepath) {