Print trailing comma in TSImportType options (#17798)

changelog_unreleased/typescript/17798.md

@@ -0,0 +1,27 @@
+#### Print trailing comma in `TSImportType` options (#17798 by @fisker)
+
+Trailing comma in import type attribute wasn't allowed before TypeScript v5.9, now [the bug](https://github.com/microsoft/TypeScript/issues/61916) has been fixed.
+
+<!-- prettier-ignore -->
+```tsx
+// Input
+type A = import("foo", {
+    with:{
+        type:'json',
+    }  // <- Should be a comma here
+})
+
+// Prettier stable
+type A = import("foo", {
+  with: {
+    type: "json",
+  } // <- Should be a comma here
+});
+
+// Prettier main
+type A = import("foo", {
+  with: {
+    type: "json",
+  }, // <- Should be a comma here
+});
+```

src/language-js/print/object.js

@@ -161,12 +161,7 @@ function printObject(path, options, print) {
           lastElem.type === "TSMethodSignature" ||
           lastElem.type === "TSConstructSignatureDeclaration" ||
           lastElem.type === "TSIndexSignature") &&
-          hasComment(lastElem, CommentCheckFlags.PrettierIgnore)))) ||
-    // https://github.com/microsoft/TypeScript/issues/61916
-    path.match(
-      undefined,
-      (node, key) => node.type === "TSImportType" && key === "options",
-    )
+          hasComment(lastElem, CommentCheckFlags.PrettierIgnore))))
   );
 
   let content;

tests/format/typescript/import-type/comma/__snapshots__/format.test.js.snap

@@ -0,0 +1,37 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`comma.ts format 1`] = `
+====================================options=====================================
+parsers: ["typescript"]
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+type A = import("foo", {
+  with: {
+  type: "json",}})
+type A = import("foo", {
+  with: {
+  type: "json"},})
+// Not supported, https://github.com/microsoft/TypeScript/issues/61489
+// type A = import("foo", {
+//   with: {
+//   type: "json"}},)
+
+=====================================output=====================================
+type A = import("foo", {
+  with: {
+    type: "json",
+  },
+});
+type A = import("foo", {
+  with: {
+    type: "json",
+  },
+});
+// Not supported, https://github.com/microsoft/TypeScript/issues/61489
+// type A = import("foo", {
+//   with: {
+//   type: "json"}},)
+
+================================================================================
+`;

tests/format/typescript/import-type/comma/comma.ts

@@ -0,0 +1,10 @@
+type A = import("foo", {
+  with: {
+  type: "json",}})
+type A = import("foo", {
+  with: {
+  type: "json"},})
+// Not supported, https://github.com/microsoft/TypeScript/issues/61489
+// type A = import("foo", {
+//   with: {
+//   type: "json"}},)

tests/format/typescript/import-type/comma/format.test.js

@@ -0,0 +1 @@
+runFormatTest(import.meta, ["typescript"]);

tests/format/typescript/import-type/long-module-name/__snapshots__/format.test.js.snap

@@ -147,13 +147,13 @@ type C = import(
   {
     with: {
       type: "json",
-    }
+    },
   }
 );
 type D = import(
   "./long/long/long/long/long/long/long/long/long/long/path/to/module",
   {
-    with: { type: "json" }
+    with: { type: "json" },
   }
 );