Fix missing parentheses around TSInstantiationExpression (#19442)

changelog_unreleased/typescript/19442.md

@@ -0,0 +1,25 @@
+#### Fix missing parentheses around instantiation expression (#19442 by @fisker)
+
+<!-- prettier-ignore -->
+```tsx
+// Input
+async function* f() {
+  makeRecord = (yield* makeRecordFactory)<ManualValue>;
+  makeRecord = (yield makeRecordFactory)<ManualValue>;
+  makeRecord = (await makeRecordFactory)<ManualValue>;
+}
+
+// Prettier stable
+async function* f() {
+  makeRecord = yield* makeRecordFactory<ManualValue>;
+  makeRecord = yield makeRecordFactory<ManualValue>;
+  makeRecord = await makeRecordFactory<ManualValue>;
+}
+
+// Prettier main
+async function* f() {
+  makeRecord = (yield* makeRecordFactory)<ManualValue>;
+  makeRecord = (yield makeRecordFactory)<ManualValue>;
+  makeRecord = (await makeRecordFactory)<ManualValue>;
+}
+```

src/language-js/parentheses/parent-needs-parentheses.js

@@ -115,6 +115,16 @@ function parentNeedsParentheses(path, options, needsParentheses) {
         return true;
       }
       break;
+
+    case "TSInstantiationExpression":
+      if (
+        key === "expression" &&
+        (node.type === "AwaitExpression" || node.type === "YieldExpression")
+      ) {
+        return true;
+      }
+
+      break;
   }
 }
 

tests/format/typescript/parentheses/__snapshots__/format.test.js.snap

@@ -0,0 +1,37 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`await.ts format 1`] = `
+====================================options=====================================
+parsers: ["typescript"]
+                                                      printWidth: 80 (default) |
+=====================================input======================================
+async function* f() {
+  makeRecord = (   await makeRecordFactory)<ManualValue>
+}
+
+=====================================output=====================================
+async function* f() {
+  makeRecord = (await makeRecordFactory)<ManualValue>;
+}
+
+================================================================================
+`;
+
+exports[`yield.ts format 1`] = `
+====================================options=====================================
+parsers: ["typescript"]
+                                                      printWidth: 80 (default) |
+=====================================input======================================
+async function* f() {
+  makeRecord = (   yield* makeRecordFactory)<ManualValue>
+  makeRecord = (    yield makeRecordFactory)<ManualValue>
+}
+
+=====================================output=====================================
+async function* f() {
+  makeRecord = (yield* makeRecordFactory)<ManualValue>;
+  makeRecord = (yield makeRecordFactory)<ManualValue>;
+}
+
+================================================================================
+`;

tests/format/typescript/parentheses/await.ts

@@ -0,0 +1,3 @@
+async function* f() {
+  makeRecord = (   await makeRecordFactory)<ManualValue>
+}

tests/format/typescript/parentheses/format.test.js

@@ -0,0 +1 @@
+runFormatTest(import.meta, ["typescript"]);

tests/format/typescript/parentheses/yield.ts

@@ -0,0 +1,4 @@
+async function* f() {
+  makeRecord = (   yield* makeRecordFactory)<ManualValue>
+  makeRecord = (    yield makeRecordFactory)<ManualValue>
+}