Drop Node.js 12 Support (#13118)

* Drop Node.js 12 Support

* Update CHANGELOG

* Update build target

* Comment out

* Remove node 14 from `exclude`

* Update CI

* Update changelog_unreleased/api/11830.md
This commit is contained in:
Sosuke Suzuki authored and GitHub committed 2022-07-17 04:26:27 +09:00
1 parent 33fcc6c4dd
commit 75c8d46ab4
4 files changed
+6 -10

No files matched your search

+1 -6
View File
@@ -71,7 +71,6 @@ jobs:
- "18"
- "16"
- "14"
- "12"
include:
- os: "ubuntu-latest"
node: "18"
@@ -79,12 +78,8 @@ jobs:
exclude:
- os: "macos-latest"
node: "16"
- os: "macos-latest"
node: "14"
- os: "windows-latest"
node: "16"
- os: "windows-latest"
node: "14"
env:
FULL_TEST: ${{ matrix.FULL_TEST }}
name: Node.js ${{ matrix.node }} on ${{ matrix.os }}
@@ -155,4 +150,4 @@ jobs:
run: node -v | grep "v0.10.48" || exit 1
- name: Run CLI on Node.js v0.10.48
run: node dist/bin-prettier --version 2>&1 >/dev/null | grep "prettier requires at least version 12.17.0 of Node, please upgrade" || exit 1
run: node dist/bin-prettier --version 2>&1 >/dev/null | grep "prettier requires at least version 14 of Node, please upgrade" || exit 1
+2 -2
View File
@@ -1,3 +1,3 @@
#### [Breaking] Drop support for Node.js 10 (#11830 by @fisker)
#### [Breaking] Drop support for Node.js 10 and 12 (#11830 by @fisker, #13118 by @sosukesuzuki)
The minimal required Node.js version is v12.17.0
The minimal required Node.js version is v14
+2 -1
View File
@@ -133,7 +133,8 @@ async function createBundle(bundleConfig, options) {
async function preparePackage() {
const packageJson = await readJson(path.join(PROJECT_ROOT, "package.json"));
packageJson.bin = "./bin-prettier.js";
packageJson.engines.node = ">=12.17.0";
// https://github.com/prettier/prettier/pull/13118#discussion_r922708068
// packageJson.engines.node = ">=14.20.0";
delete packageJson.dependencies;
delete packageJson.devDependencies;
delete packageJson.browserslist;
+1 -1
View File
@@ -210,7 +210,7 @@ function* getEsbuildOptions(bundle, buildOptions) {
external: ["pnpapi", ...(bundle.external ?? [])],
// Disable esbuild auto discover `tsconfig.json` file
tsconfig: path.join(dirname, "empty-tsconfig.json"),
target: [...(bundle.esbuildTarget ?? ["node12"])],
target: [...(bundle.esbuildTarget ?? ["node14"])],
logLevel: "error",
};